os: refactor to use os.stat and os.lstat instead of unsafe C calls #20759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st_mod with os.stat
spytheman
reviewed
Feb 8, 2024
| fn eprintln_unknown_file_size() { | ||
| eprintln('os.file_size() Cannot determine file-size: ' + posix_get_error_msg(C.errno)) | ||
| } | ||
|
|
||
| // file_size returns the size of the file located in `path`. | ||
| // If an error occurs it returns 0. | ||
| // Note that use of this on symbolic links on Windows returns always 0. | ||
| pub fn file_size(path string) u64 { |
There was a problem hiding this comment.
Can you check, if that works with files larger than 4GB on windows?
There was a problem hiding this comment.
Confirmed; works on 32- and 64-bit Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: simplify
oscodebase and reduce number of unsafe blocks.Changes:
When appropriate because of Win API instead of C lib calls, split functions between os_stat_default.c.v or os_stat_windows.c.v.
Regression tested with existing os tests.